Skip to content

Removed in_band_lifetimes from rustc_traits#91929

Merged
bors merged 1 commit intorust-lang:masterfrom
lameferret:remove_in_band_lifetimes_compiler_rustc_traits
Dec 31, 2021
Merged

Removed in_band_lifetimes from rustc_traits#91929
bors merged 1 commit intorust-lang:masterfrom
lameferret:remove_in_band_lifetimes_compiler_rustc_traits

Conversation

@lameferret
Copy link
Contributor

@lameferret lameferret commented Dec 14, 2021

Issue: #91867

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 14, 2021
@rust-highfive
Copy link
Contributor

rust-highfive commented Dec 14, 2021

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2021
@jackh726 jackh726 mentioned this pull request Dec 14, 2021
Closed
21 tasks
@camelid
Copy link
Member

camelid commented Dec 14, 2021

Please use a more descriptive commit message, e.g. that matches the PR title.

@jackh726
Copy link
Member

jackh726 commented Dec 16, 2021

LGTM after commit message changed

@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2021
@Aaron1011 Aaron1011 force-pushed the remove_in_band_lifetimes_compiler_rustc_traits branch from 6d0c879 to 58a888f Compare December 30, 2021 19:00
@Aaron1011
Copy link
Contributor

Aaron1011 commented Dec 30, 2021

@bors r=jackh726

@bors
Copy link
Collaborator

bors commented Dec 30, 2021

📌 Commit 58a888f has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 30, 2021
@bors
Copy link
Collaborator

bors commented Dec 31, 2021

⌛ Testing commit 58a888f with merge e670844...

@bors
Copy link
Collaborator

bors commented Dec 31, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing e670844 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 31, 2021
@bors bors merged commit e670844 into rust-lang:master Dec 31, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 31, 2021
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 31, 2021

Finished benchmarking commit (e670844): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nagisa nagisa

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.59.0

Development

Successfully merging this pull request may close these issues.

9 participants

@lameferret @rust-highfive @camelid @jackh726 @Aaron1011 @bors @rust-timer @nagisa @rustbot