Skip to content

Rollup of 4 pull requests#90695

Merged
bors merged 10 commits intorust-lang:masterfrom
GuillaumeGomez:rollup-kxvvw4o
Nov 9, 2021
Merged

Rollup of 4 pull requests#90695
bors merged 10 commits intorust-lang:masterfrom
GuillaumeGomez:rollup-kxvvw4o

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Nov 8, 2021

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Meziu and others added 10 commits November 2, 2021 08:44
@Meziu
ARMv6K Horizon OS panic change
9cab312
@Meziu
Updated backtrace submodule
d379147
@matthiaskrgr
use filter(|x| matches!(..)) instead of filter_map(|x| match x ... =>…
ed7e438 
… Some(xy))
@GuillaumeGomez
Fix last doc code comment being removed if it only had one character
e8f1d57
@GuillaumeGomez
Add test for removed one character last line in rustdoc
aa6f6f4
@lnicola
⬆️ rust-analyzer
1e56dd4
@GuillaumeGomez
Rollup merge of rust-lang#90494 - Meziu:armv6k-3ds-target, r=sanxiyn
f07f800 
ARMv6K Horizon OS panic change

After a small change to `backtrace-rs` ([rust-lang#448](rust-lang/backtrace-rs#448)), `PanicStrategy::Unwind` is now fully supported.
@GuillaumeGomez
Rollup merge of rust-lang#90652 - matthiaskrgr:unnnec_filter_map, r=j…
9318810 
…yn514

use filter(|x| matches!(..)) instead of filter_map(|x| match x ... => Some(xy))
@GuillaumeGomez
Rollup merge of rust-lang#90657 - GuillaumeGomez:one-char-last-line-r…
d9fc7d1 
…emoved, r=jyn514

Fix bug with `#[doc]` string single-character last lines

Fixes rust-lang#90618.

This is because `.iter().all(|c| c == '*')` returns `true` if there is no character checked. And in case the last line has only one character, it simply returns `true`, making the last line behind removed.
@GuillaumeGomez
Rollup merge of rust-lang#90689 - lnicola:rust-analyzer-2021-11-08, r…
2709524 
…=lnicola

⬆️ rust-analyzer

r? ``@ghost``
@rustbot rustbot added the rollup A PR which is a rollup label Nov 8, 2021
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Nov 8, 2021

@bors: r+ p=4 rolup=never

@bors
Copy link
Collaborator

bors commented Nov 8, 2021

📌 Commit 2709524 has been approved by GuillaumeGomez

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 8, 2021
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Nov 8, 2021

@bors: rollup=never

@bors
Copy link
Collaborator

bors commented Nov 8, 2021

⌛ Testing commit 2709524 with merge 839e685abf0334d9b311fe8df73d30c861981d3c...

@bors bors mentioned this pull request Nov 8, 2021
Merged
@bors
Copy link
Collaborator

bors commented Nov 8, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 8, 2021
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Nov 8, 2021

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Nov 8, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2021
@bors
Copy link
Collaborator

bors commented Nov 9, 2021

⌛ Testing commit 2709524 with merge c57704f...

@bors
Copy link
Collaborator

bors commented Nov 9, 2021

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing c57704f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 9, 2021
@bors bors merged commit c57704f into rust-lang:master Nov 9, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 9, 2021
@bors bors mentioned this pull request Nov 9, 2021
Closed
@rust-timer
Copy link
Collaborator

rust-timer commented Nov 9, 2021

Finished benchmarking commit (c57704f): comparison url.

Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.

  • Moderate improvement in instruction counts (up to -0.5% on full builds of deeply-nested-async)
  • Small regression in instruction counts (up to 0.3% on incr-unchanged builds of html5ever)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Nov 9, 2021
@GuillaumeGomez GuillaumeGomez deleted the rollup-kxvvw4o branch November 9, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.58.0

Development

Successfully merging this pull request may close these issues.

8 participants

@GuillaumeGomez @bors @rust-log-analyzer @rust-timer @rustbot @Meziu @matthiaskrgr @lnicola