Add LetSource to hir::ExprKind::Let#88187
Closed
camsteffen wants to merge 3 commits intorust-lang:masterfrom
Closed
Add LetSource to hir::ExprKind::Let#88187camsteffen wants to merge 3 commits intorust-lang:masterfrom
LetSource to hir::ExprKind::Let#88187camsteffen wants to merge 3 commits intorust-lang:masterfrom
Conversation
Contributor
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
Merged
Member
cjgillot
reviewed
Aug 24, 2021
cjgillot
reviewed
Aug 24, 2021
cjgillot
reviewed
Aug 24, 2021
| } | ||
|
|
||
| #[derive(Copy, Clone, Debug, PartialEq)] | ||
| enum ConditionScope { |
Contributor
There was a problem hiding this comment.
Why have separate LetSource and ConditionScope types?
Contributor
Author
There was a problem hiding this comment.
Yeah I guess they are interchangeable. It's just that LetSource makes more sense in ExprKind::Let and Option<ConditionScope> makes more sense in LoweringContext. Should I just use LetSource?
cjgillot
reviewed
Aug 24, 2021
Contributor
Author
|
It occurred to me that this may be unnecessary. LetSource sort of conflates desugaring kind with HIR ancestor context. And I think the LetSource calculation can easily be moved off of the happy path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...instead of determining
LetSourceusinghir::Map. This is used in #87688. And it may also be useful for factoring outGuard::IfLet.