Simplification of query forcing#85319
Conversation
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
⌛ Trying commit c95a568 with merge 33b3829763888e5ceeb3857c70ae07e617d89472... |
|
☀️ Try build successful - checks-actions |
|
Queued 33b3829763888e5ceeb3857c70ae07e617d89472 with parent 428636f, future comparison URL. |
|
Finished benchmarking try commit (33b3829763888e5ceeb3857c70ae07e617d89472): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
Perf looks good! But going to r? @Aaron1011 (to review or reassign) since this is an area I'm unfamiliar with. |
|
I can take a look at this. |
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
Might be best for a separate PR so we can evaluate performance on it standalone. Otherwise r=me, feel free to include here or not.
| } | ||
|
|
||
| false | ||
| force_query::<queries::$name<'_>, _>(tcx, dep_node) |
There was a problem hiding this comment.
Can we directly take a function pointer to this rather than (hoping) that LLVM sees through this layer of indirection?
There was a problem hiding this comment.
I get a higher-ranked subtype error when trying to take a function pointer.
There was a problem hiding this comment.
Hm, that seems unfortunate. Feel free to re-run perf and/or r=me as I said.
|
Perf hit on rustc_query_impl compilation: 105.485 to 112.492 (6.6%) seems a bit unfortunate. I wouldn't worry about it too much but just wanted to note that here; not really clear what's responsible for it in this PR. |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
⌛ Trying commit f3ed997 with merge 2556e75c882abef9a681bb59e4dd51067fa1148e... |
|
☀️ Try build successful - checks-actions |
|
Queued 2556e75c882abef9a681bb59e4dd51067fa1148e with parent ff5522f, future comparison URL. |
|
Finished benchmarking try commit (2556e75c882abef9a681bb59e4dd51067fa1148e): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
@bors r=Mark-Simulacrum |
|
📌 Commit f3ed997 has been approved by |
|
☀️ Test successful - checks-actions |
Extracted from #78780