r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@bors try @rust-timer queue

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

⌛ Trying commit 3341e59a51aae0f4e7563201909c9c40e741503b with merge 4b5ec6fb38614d722c06f0f0de0d68e5dbaeea93...

☀️ Try build successful - checks-actions
Build commit: 4b5ec6fb38614d722c06f0f0de0d68e5dbaeea93 (4b5ec6fb38614d722c06f0f0de0d68e5dbaeea93)

Queued 4b5ec6fb38614d722c06f0f0de0d68e5dbaeea93 with parent ff34b91, future comparison URL.

Finished benchmarking try commit (4b5ec6fb38614d722c06f0f0de0d68e5dbaeea93): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@bors try @rust-timer queue

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

⌛ Trying commit 3341e59a51aae0f4e7563201909c9c40e741503b with merge 91eef17632935ce04682e8e7bdc0ce65a52370d9...

☀️ Try build successful - checks-actions
Build commit: 91eef17632935ce04682e8e7bdc0ce65a52370d9 (91eef17632935ce04682e8e7bdc0ce65a52370d9)

Queued 91eef17632935ce04682e8e7bdc0ce65a52370d9 with parent 17f30e5, future comparison URL.

Finished benchmarking try commit (91eef17632935ce04682e8e7bdc0ce65a52370d9): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

Overall improvements up to 1.0% with 3 regressions of up to 0.5%.

I am not able to review any PRs in the near future.

r? @matthewjasper

@bors r+

📌 Commit 3341e59a51aae0f4e7563201909c9c40e741503b has been approved by matthewjasper

@nikomatsakis: I added a region to Third, which preserves the existing EvaluatedToOk and EvaluatedToOkModuloRegions results.

@bors r=matthewjasper,jackh726

📌 Commit 1f7cb16 has been approved by matthewjasper,jackh726

⌛ Testing commit 1f7cb16 with merge cf65b707d871d443059f2b9881cfbd6cf31d850b...

💔 Test failed - checks-actions

A job failed! Check out the build log: (web) (plain)

@bors retry

This PR doesn't fix the root cause of the evaluate_obligation unstable fingerprint ICEs, but it should make them less common (since we'll never produce EvaluatedToOkModuloRegions in more cases).

⌛ Testing commit 1f7cb16 with merge d34a3a4...

☀️ Test successful - checks-actions
Approved by: matthewjasper,jackh726
Pushing d34a3a4 to master...