Skip to content

make feature name plural: const_fn_trait_bound → const_fn_trait_bounds#84578

Closed
RalfJung wants to merge 1 commit intorust-lang:masterfrom
RalfJung:const_fn_trait_bounds
Closed

make feature name plural: const_fn_trait_bound → const_fn_trait_bounds#84578
RalfJung wants to merge 1 commit intorust-lang:masterfrom
RalfJung:const_fn_trait_bounds

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Apr 26, 2021 •
edited
Loading

Seems like we usually use plural for this -- and even though I picked the name I also keep expecting it to be plural.^^
No nightly has been released yet with the singular name (Cc #84577), so if we are quick I think this will be rather painless.

Cc @oli-obk

@rust-highfive
Copy link
Contributor

rust-highfive commented Apr 26, 2021

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung RalfJung force-pushed the const_fn_trait_bounds branch from eca7301 to 6e349d1 Compare April 26, 2021 08:37
@oli-obk
Copy link
Contributor

oli-obk commented Apr 26, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 26, 2021

📌 Commit 6e349d1 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2021
@RalfJung
Copy link
Member Author

RalfJung commented Apr 26, 2021

Okay turns out there was a nightly, my rustup just skipped it due to missing tools.
Do we still want to go ahead with the rename (and just hope that not too many people start using this feature flag today)?

@bors
Copy link
Collaborator

bors commented Apr 26, 2021

⌛ Testing commit 6e349d1 with merge 7a71a9a89069b05f047f313f2c649aa97f4f4b8c...

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Apr 26, 2021

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  2  516M    2 13.6M    0     0  24.6M      0  0:00:20 --:--:--  0:00:20 24.7M
curl: (56) OpenSSL SSL_read: Connection was reset, errno 10054

gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now
##[error]Process completed with exit code 2.
[command]"C:\Program Files\Git\bin\git.exe" version
git version 2.31.1.windows.1
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp core\.sshCommand
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
http.https://github.com/.extraheader
[command]"C:\Program Files\Git\bin\git.exe" config --local --unset-all http.https://github.com/.extraheader
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Cleaning up orphan processes
Terminate orphan process: pid (8012) (node)
Terminate orphan process: pid (8136) (python)
Terminate orphan process: pid (2880) (vctip)

@bors
Copy link
Collaborator

bors commented Apr 26, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 26, 2021
@RalfJung
Copy link
Member Author

RalfJung commented Apr 26, 2021

Transient failure:

Run src/ci/scripts/install-clang.sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  2  516M    2 13.6M    0     0  24.6M      0  0:00:20 --:--:--  0:00:20 24.7M
curl: (56) OpenSSL SSL_read: Connection was reset, errno 10054

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2021
@RalfJung RalfJung mentioned this pull request Apr 26, 2021
Merged
@bors
Copy link
Collaborator

bors commented Apr 26, 2021

⌛ Testing commit 6e349d1 with merge dfaeef409902931d5293d921bbc52369b3bcac70...

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Apr 26, 2021

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  4273  100  4273    0     0  12987      0 --:--:-- --:--:-- --:--:-- 12987
+ RUSTC_BOOTSTRAP=1
+ ./build/x86_64-unknown-linux-gnu/stage2/bin/rustc --edition=2018 --crate-type=lib /tmp/ctfe-stress-4.rs
error[E0658]: trait bounds other than `Sized` on const fn parameters are unstable
   |
   |
67 | expensive_static!(UNSIZE_TRAIT: &'static dyn Trait = &42u32; [4 16 16 16 16 16]);
   |
   = note: see issue #57563 <https://github.com/rust-lang/rust/issues/57563> for more information
   = help: add `#![feature(const_fn_trait_bounds)]` to the crate attributes to enable

@bors
Copy link
Collaborator

bors commented Apr 26, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 26, 2021
@RalfJung
Copy link
Member Author

RalfJung commented Apr 26, 2021

Argh, I forgot about the CTFE stress test...
well I guess we are stuck with the singular feature name then. shrug this doesn't seem worth the effort.

@RalfJung RalfJung closed this Apr 26, 2021
@RalfJung RalfJung deleted the const_fn_trait_bounds branch April 26, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@estebank estebank

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RalfJung @rust-highfive @rust-log-analyzer @oli-obk @bors @estebank