Skip to content

update Miri#82150

Merged
bors merged 1 commit intorust-lang:masterfrom
RalfJung:miri
Feb 16, 2021
Merged

update Miri#82150
bors merged 1 commit intorust-lang:masterfrom
RalfJung:miri

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Feb 15, 2021 •
edited
Loading

This pulls in the recent cargo-miri fixes by @hyd-dev.
Cc @rust-lang/miri r? @ghost
Fixes #82173

@RalfJung
Copy link
Member Author

RalfJung commented Feb 15, 2021

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Feb 15, 2021

📌 Commit 7c31594361936b28004670ef3bde7dbcbb3c78d0 has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 15, 2021
@RalfJung
Copy link
Member Author

RalfJung commented Feb 16, 2021

@bors r-
Something broke Miri

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 16, 2021
@RalfJung
Copy link
Member Author

RalfJung commented Feb 16, 2021

Miri should be good again.
@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Feb 16, 2021

📌 Commit 92764ac has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 16, 2021
@bors
Copy link
Collaborator

bors commented Feb 16, 2021

⌛ Testing commit 92764ac with merge b45686151896bab7a830eaa57089e336fa14b896...

@bors
Copy link
Collaborator

bors commented Feb 16, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 16, 2021
@RalfJung
Copy link
Member Author

RalfJung commented Feb 16, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2021
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Feb 16, 2021

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Feb 16, 2021

⌛ Testing commit 92764ac with merge 9d3deed...

@bors
Copy link
Collaborator

bors commented Feb 16, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 9d3deed to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 16, 2021
@bors bors merged commit 9d3deed into rust-lang:master Feb 16, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 16, 2021
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Feb 16, 2021

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
  CACHE_DOMAIN: ci-caches.rust-lang.org
  TOOLSTATE_REPO_ACCESS_TOKEN: ***
##[endgroup]
Cloning into 'rust-toolstate'...
/home/runner/work/rust/rust/src/tools/publish_toolstate.py:121: DeprecationWarning: 'U' mode is deprecated
📣 Toolstate changed by rust-lang/rust#82150!
  with open(path, 'rU') as f:

Tested on commit rust-lang/rust@9d3deed8a2f7dca16869ccd03a8e328ef627e6eb.
Direct link to PR: <https://github.com/rust-lang/rust/pull/82150>

🎉 miri on windows: test-fail → test-pass (cc @eddyb @oli-obk @RalfJung).
🎉 miri on linux: test-fail → test-pass (cc @eddyb @oli-obk @RalfJung).
Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/runner/work/rust/rust/src/tools/publish_toolstate.py", line 338, in <module>
    response = urllib2.urlopen(urllib2.Request(
  File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.8/urllib/request.py", line 522, in open
    req = meth(req)
  File "/usr/lib/python3.8/urllib/request.py", line 1281, in do_request_
    raise TypeError(msg)
TypeError: POST data should be bytes, an iterable of bytes, or a file object. It cannot be of type str.
##[error]Process completed with exit code 1.

@RalfJung
Copy link
Member Author

RalfJung commented Feb 18, 2021

@rust-lang/infra something seems to be wrong with toolstate tracking? https://rust-lang-nursery.github.io/rust-toolstate/ did not update when this PR got merged, and now Miri fails to build and there was no notification or issue being created.

@RalfJung RalfJung deleted the miri branch February 18, 2021 09:25
@ghost
Copy link

ghost commented Feb 18, 2021

@rust-lang/infra something seems to be wrong with toolstate tracking? https://rust-lang-nursery.github.io/rust-toolstate/ did not update when this PR got merged, and now Miri fails to build and there was no notification or issue being created.

That seems a Python 2 → Python 3 issue: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Toolstate.20update.20was.20broken.20for.20Miri

@RalfJung RalfJung mentioned this pull request Feb 18, 2021
Closed
@RalfJung
Copy link
Member Author

RalfJung commented Feb 18, 2021

Okay, I created an issue to track this: #82254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.52.0

Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#82153

4 participants

@RalfJung @bors @rust-log-analyzer @rustbot