Add suggestion for PATTERNS_IN_FNS_WITHOUT_BODY#79414
Merged
bors merged 2 commits intorust-lang:masterfrom Jan 10, 2021
Merged
Conversation
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
2125d28 to
03c5c0b
Compare
Contributor
|
I think that it makes sense to keep this being buffered in ast validation, since that's where the error is emitted for more complex patterns. To be able to add a suggestion for a buffered lint, you can add a variant to |
03c5c0b to
3e6cf36
Compare
Contributor
Author
|
@matthewjasper Thanks for your suggestion! |
3e6cf36 to
e97b97e
Compare
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit e97b97e has been approved by |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix #78927