Don't warn if the config file is somewhere other than config.toml#77298
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 30, 2020
Merged
Don't warn if the config file is somewhere other than config.toml#77298bors merged 1 commit intorust-lang:masterfrom
config.toml#77298bors merged 1 commit intorust-lang:masterfrom
Conversation
Previously, `config.config` was always hardcoded as `"config.toml"`. I thought that it was being overridden with the actual value later, but it turns out `flags.config` was being completely discarded. This keeps `config.config` in sync with `flags.config`.
Member
|
@bors r+ |
Collaborator
|
📌 Commit d537067 has been approved by |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
config.configwas always hardcoded as"config.toml".I thought that it was being overridden with the actual value later, but
it turns out
flags.configwas being completely discarded. This keepsconfig.configin sync withflags.config.Fixes #77293
r? @Mark-Simulacrum
cc @davidtwco