Deny unsafe operations in unsafe fns in libstd/sync/#74278
Deny unsafe operations in unsafe fns in libstd/sync/#74278poliorcetics wants to merge 2 commits intorust-lang:masterfrom
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
I suspect that fixing these may not be worth it -- they look like they're all related to the mpsc module which is essentially abandoned at this point (and there's ongoing experiments in the ecosystem which are looking to replace it).
92acbb2 to
8ec744d
Compare
|
@poliorcetics Would you be opposed to just closing this? This is currently not quite in the shape that I'd like it to be for merging it and I feel like it would be better to dedicate time elsewhere -- editing the mpsc code is pretty much not viable today due to lack of good reviewers, and so I'd rather not spend time hashing out good safety annotations. |
|
No problems on my side, go ahead. |
|
@Mark-Simulacrum I think we should have a PR adding just the unsafe blocks then? @polioretics would you mind filing a PR for that? |
|
I don't think there's any point to doing so, we can just allow the lint for this module. |
Partial fix of #73904.
This encloses
unsafeoperations inunsafe fninlibstd/sync/.@rustbot modify labels: F-unsafe-block-in-unsafe-fn