Const prop aggregates even if partially or fully modified#71953
Const prop aggregates even if partially or fully modified#71953bors merged 1 commit intorust-lang:masterfrom
Conversation
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit a1ebb94 with merge 274c308239850d9f5a2a2a9067bcc5c41ab35a6d... |
wesleywiser
left a comment
There was a problem hiding this comment.
Agreed: it does seem a bit scary but the code appears correct. Let's see what perf says.
|
☀️ Try build successful - checks-actions, checks-azure |
|
Queued 274c308239850d9f5a2a2a9067bcc5c41ab35a6d with parent 97f3eee, future comparison URL. |
|
Let's try that again: @rust-timer queue 274c308239850d9f5a2a2a9067bcc5c41ab35a6d |
|
Awaiting bors try build completion |
|
Oh, looks like it's still in the queue... |
|
@rust-timer build 274c308239850d9f5a2a2a9067bcc5c41ab35a6d |
|
Queued 274c308239850d9f5a2a2a9067bcc5c41ab35a6d with parent 97f3eee, future comparison URL. |
|
Finished benchmarking try commit 274c308239850d9f5a2a2a9067bcc5c41ab35a6d, comparison URL. |
|
@rust-timer build 274c308 |
|
Queued 274c308239850d9f5a2a2a9067bcc5c41ab35a6d with parent 97f3eee, future comparison URL. |
|
Perf shows minimal improvement. |
|
I think we mostly wanted to make sure this didn't cause any regressions. @bors r+ |
|
📌 Commit a1ebb94 has been approved by |
|
☀️ Test successful - checks-actions, checks-azure |
r? @wesleywiser
cc @rust-lang/wg-mir-opt I'm moderately scared of this change, but I'm confident in having reviewed all the cases.