Merged
Conversation
…scope` Calls to `assemble_extension_candidates_for_traits_in_scope` with `DUMMY_HIR_ID` as `expr_hir_id` are useless because the first thing that this function does is to return `Ok(())` in this case.
A valid hir id should always be returned in this case.
Those usage ends up forwarded to a `ObligationClause` which uses `CRATE_HIR_ID` for dummy value as seen in `ObligationClause::dummy`.
…crum Explain how to work with subtree cc rust-lang#70651 r? @Centril @RalfJung This PR just contains the usage documentation, we'll do actual moves in later PRs
…=eddyb Remove some usage of `DUMMY_HIR_ID`
Add test case for type aliasing `impl Sized` Fixes rust-lang#71085
Author
|
@bors r+ p=4 rollup=never |
Collaborator
|
📌 Commit dd27462 has been approved by |
Collaborator
Collaborator
|
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
DUMMY_HIR_ID#71092 (Remove some usage ofDUMMY_HIR_ID)impl Sized#71103 (Add test case for type aliasingimpl Sized)Failed merges:
r? @ghost