Conversation
|
☔ The latest upstream changes (presumably #31882) made this pull request unmergeable. Please resolve the merge conflicts. |
If there's nothing to do, returning early saves an indentation level and reduces the amount of state one needs to track reading the code.
Generate an unix-style ldflags line when building with --crate-type staticlib --emit link-flags-ld. If a filename is given, write the link line there for later use by an external build system in linking the static library. If none is given, just modify the normal informative message to print the flags line instead of the library list. Issue rust-lang#31471.
|
Thanks @rillian! I think we may want to document this as well somewhere. I guess the best place may be... the man page? I don't think we have exhaustive docs in the reference for this right now... Also in terms of tests, yeah we'll want to add some tests for this along the lines of:
etc You should be able to add a test by just creating a directory in cc @rust-lang/tools, this is also adding what would essentially be a new insta-stable emission type of the compiler. |
0ef6fca to
cdcc1a4
Compare
|
Thanks for the feedback, @alexcrichton. I've rebased around the bit-rot. Will add tests and documentation. |
|
Closing due to inactivity, but feel free to resubmit with the tests + docs! |
Attempt to address #31471. r? @alexcrichton