Skip to content

unused_macro_rules switched used and unused comments#153717

Open
ralpha wants to merge 1 commit intorust-lang:mainfrom
ralpha:unused_macro_rules-lint-correction
Open

unused_macro_rules switched used and unused comments#153717
ralpha wants to merge 1 commit intorust-lang:mainfrom
ralpha:unused_macro_rules-lint-correction

Conversation

@ralpha
Copy link

@ralpha ralpha commented Mar 11, 2026

Incorrect swapping of "used" and "unused".

The lint example:

#[warn(unused_macro_rules)]
macro_rules! unused_empty {
    (hello) => { println!("Hello, world!") }; // This rule is unused
    () => { println!("empty") }; // This rule is used
}

fn main() {
    unused_empty!(hello);
}

It is clearly using the (hello) case. Yet it is labeled as "unused".
This PR fixed that small issue and corrects the mistake.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 11, 2026

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 16 candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants