Skip to content

add test that all incomplete features emit a warning#153706

Open
cyrgani wants to merge 1 commit intorust-lang:mainfrom
cyrgani:incompleteness-test
Open

add test that all incomplete features emit a warning#153706
cyrgani wants to merge 1 commit intorust-lang:mainfrom
cyrgani:incompleteness-test

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Mar 11, 2026

Related to rust-lang/compiler-team#974, this PR adds a new test to specifically check that all incomplete features trigger the incomplete_features lint.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 11, 2026

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 16 candidates

fmease
fmease reviewed Mar 11, 2026
View reviewed changes
Copy link
Member

@fmease fmease left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unfortunate how we have to basically duplicate the stderr file just because two features are incompatible with each other.

I could see myself considering having a separate file for each feature in a separate directory, similar to our mandatory feature gate error tests..

Would you be down to experiment with a new tidy check in this PR? The design+impl of such a check could inform us which approach is most feasible. cc Zulip comment of mine.

@fmease
Copy link
Member

fmease commented Mar 11, 2026 •
edited
Loading

However note my Zulip comments I just posted below in which I entirely question the idea of testing the incompleteness of every single relevant feature.

@cyrgani cyrgani mentioned this pull request Mar 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmease fmease fmease left review comments

Assignees

@fmease fmease

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyrgani @rustbot @fmease