Implement context-aware validation for SIMD MIR projections (MCP#838)#153703
Open
Delta17920 wants to merge 1 commit intorust-lang:mainfrom
Open
Implement context-aware validation for SIMD MIR projections (MCP#838)#153703Delta17920 wants to merge 1 commit intorust-lang:mainfrom
Delta17920 wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Collaborator
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@rustbot reroll |
Contributor
|
I think r? @scottmcm mMight be a more appropriate reviewer? I don't know this stuff at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow expressions like
self.0[2]on simd types by permittingfield 0as an intermediate projection step when followed by an index projection. standalone field access likea.0remains banned.changes:
as_place.rs: allowfield 0through for simd, block all other fieldsstatement.rs: teachprojection_ty_corethe element type of simd indexplace.rs: peel simd struct wrapper before computing codegen offsetsvalidate.rs: ban field projections on simd unless followed by an indexFixes #153636