Skip to content

find_dep_kind_root tweaks#153690

Open
nnethercote wants to merge 2 commits intorust-lang:mainfrom
nnethercote:find_dep_kind_root
Open

find_dep_kind_root tweaks#153690
nnethercote wants to merge 2 commits intorust-lang:mainfrom
nnethercote:find_dep_kind_root

Conversation

@nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Mar 11, 2026

Two minor changes relating to find_dep_kind_root.

r? @SparrowLii

@nnethercote
Streamline find_dep_kind_root.
134d666 
`current_id` is removable.
@nnethercote
Remove Clone derive on QueryJobInfo.
4e4f8a8 
This requires refactoring `depth_limit_error` to do some extra work
immediately instead of returning a cloned `info`.
@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 11, 2026

SparrowLii is not on the review rotation at the moment.
They may take a while to respond.

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Mar 11, 2026

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
##[endgroup]
Executing "/scripts/stage_2_test_set1.sh"
+ /scripts/stage_2_test_set1.sh
+ '[' 1 == 1 ']'
+ echo 'PR_CI_JOB set; skipping tidy'
+ SKIP_TIDY='--skip tidy'
+ ../x.py --stage 2 test --skip tidy --skip compiler --skip src
PR_CI_JOB set; skipping tidy
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
---
   Compiling compiler_builtins v0.1.160 (/checkout/library/compiler-builtins/compiler-builtins)
[RUSTC-TIMING] build_script_build test:false 0.332
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

Session terminated, killing shell...::group::Clock drift check
  local time: Wed Mar 11 04:49:59 UTC 2026
  network time: Wed, 11 Mar 2026 04:49:59 GMT
##[endgroup]
 ...killed.
##[error]The operation was canceled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SparrowLii SparrowLii

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nnethercote @rustbot @rust-log-analyzer @SparrowLii