Open
Conversation
Collaborator
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
This comment has been minimized.
This comment has been minimized.
b6c1120 to
948df5b
Compare
948df5b to
8aec809
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when
note_and_explain_type_erris called during dyn-compatibility checking, thebody_owner_def_idcan beCRATE_DEF_IDbecauseObligationCause::dummy()uses it as a placeholder when there is no real body owner. callinggenerics_ofonCRATE_DEF_IDcaused an ICE because the crate root is a module and modules don't have generics. the fix guards allgenerics_ofcall sites by checking whetherbody_owner_def_idisCRATE_DEF_IDbefore attempting to look up generics, and skips the type parameter span labeling in that case.i also added regression test with original ice reproduce
fixes #152335