fix inference variables leaking into HIR const literal lowering logic#153557
Open
Human9000-bit wants to merge 1 commit intorust-lang:mainfrom
Open
fix inference variables leaking into HIR const literal lowering logic#153557Human9000-bit wants to merge 1 commit intorust-lang:mainfrom
Human9000-bit wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
HIR ty lowering was modified cc @fmease |
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
r? BoxyUwU |
995857f to
28de380
Compare
This comment has been minimized.
This comment has been minimized.
28de380 to
a39c4a4
Compare
Human9000-bit
commented
Mar 8, 2026
| let tcx = self.tcx(); | ||
|
|
||
| if ty.has_infer() { | ||
| let e = self.dcx().span_err(span, "inference variables are not supported in constants"); |
Contributor
Author
There was a problem hiding this comment.
I am sure this is pretty suboptimal error message. Could we think about a correct one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inference variables could leak into further const lowering logic
It ICEs when query system tries to cache
lit_to_const()after its execution and panics, because inference variables are not hashable for some reasonFixes #153524
Fixes #153525