Open
Conversation
Contributor
Author
f7db4d8 to
53123a4
Compare
53123a4 to
f6b4e4e
Compare
This comment has been minimized.
This comment has been minimized.
f6b4e4e to
951e9d7
Compare
Contributor
Author
|
Removed the test I added in commit 1, since we already test similar behavior somewhere else (see the other test I blessed). Kept it in the first commit to demonstrate old behavior. |
JonathanBrouwer
approved these changes
Mar 9, 2026
| @@ -618,15 +612,23 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> { | |||
| } | |||
|
|
|||
| // Report errors for the resolved macro. | |||
| let mut first = true; | |||
| for segment in &path.segments { | |||
Contributor
There was a problem hiding this comment.
nit: I'd prefer doing this with enumerate rather than a variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @petrochenkov
I noticed that attributes containing the word rustc as a segment also error with a message referring to "starting with rustc". The first commit shows this going wrong by re-exporting
#[test], a built-in macro, from a module called rustc.The 2nd commit addresses this by changing the diagnostic. However, given the wording I wonder if the real solution shouldn't be to allow attributes containing a
rustcsegment and only disallow them when they start. In other words, actually implement the behavior that the original diagnostic pointed out.