Skip to content

Move freeze_* methods to OpenOptionsExt2#153491

Open
ChrisDenton wants to merge 1 commit intorust-lang:mainfrom
ChrisDenton:openoptionsext2
Open

Move freeze_* methods to OpenOptionsExt2#153491
ChrisDenton wants to merge 1 commit intorust-lang:mainfrom
ChrisDenton:openoptionsext2

Conversation

@ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented Mar 6, 2026 •
edited by rustbot
Loading

Move the unstable freeze_last_access_time and freeze_last_write_time from OpenOptionsExt to a new OpenOptionsExt2 trait. This should fix #153486.

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 6, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2026

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, joboet

@joboet
Copy link
Member

joboet commented Mar 6, 2026

r? libs-api
But I wonder whether it would make sense to retroactively make all these extension traits sealed. I can't imagine that there are too many people that implement this...

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 6, 2026
@rustbot rustbot assigned Amanieu and unassigned joboet Mar 6, 2026
@Darksonn
Copy link
Member

Darksonn commented Mar 9, 2026

Is the intent to make a stable point release for this?

@jieyouxu
Copy link
Member

jieyouxu commented Mar 10, 2026

Given that as mentioned

As far as I can tell, crates affected by this have no way to fix this build error without a breaking change because it's impossible to provide an implementation of the unstable method freeze_last_access_time.

Nominating for 1.95 beta / 1.94.1 stable backports for T-libs/T-libs-api judgement call.
@rustbot label: +beta-nominated +stable-nominated

@rustbot rustbot added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Mar 10, 2026
@joshtriplett
Copy link
Member

joshtriplett commented Mar 10, 2026

Seems reasonable. Could you please add a (non-doc) comment to OpenOptionsExt saying to add new methods to OpenOptionsExt2 instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Amanieu Amanieu

Labels

beta-nominated Nominated for backporting to the compiler in the beta channel. O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. stable-nominated Nominated for backporting to the compiler in the stable channel. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Breaking change in std::os::windows::fs::OpenOptionsExt affecting 1.94.0

7 participants

@ChrisDenton @rustbot @joboet @Darksonn @jieyouxu @joshtriplett @Amanieu