fix(interp): Treat UnsafeBinder as Compound Type in try_visit_primitive#153458
Open
TKanX wants to merge 1 commit intorust-lang:mainfrom
Open
fix(interp): Treat UnsafeBinder as Compound Type in try_visit_primitive#153458TKanX wants to merge 1 commit intorust-lang:mainfrom
UnsafeBinder as Compound Type in try_visit_primitive#153458TKanX wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
Member
|
can you explain a bit your choice of this match arm? |
Contributor
Author
Since layout.rs erases bound regions and delegates entirely to the inner type, I think returning Happy to be corrected if there's something specific. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes ICE in const eval validity checking when a value contains an
UnsafeBinder-typed field.try_visit_primitiveinvalidity.rshadty::UnsafeBinder(_) => todo!("FIXME(unsafe_binder)"): a placeholder left by the initial unsafe binders type system implementation (9a1c5eb).The fix is to remove the
todo!()and moveUnsafeBinderinto the compound types arm.Closes #153362
r? @dingxiangfei2009
cc @matthiaskrgr