Fix some comments about dataflow analysis.#153432
Open
nnethercote wants to merge 1 commit intorust-lang:mainfrom
Open
Fix some comments about dataflow analysis.#153432nnethercote wants to merge 1 commit intorust-lang:mainfrom
nnethercote wants to merge 1 commit intorust-lang:mainfrom
Conversation
Mostly in the examples in `initialized.rs`. In particular, the `EverInitializedPlaces` example currently doesn't cover how it's initialization sites that are tracked, rather than local variables (that's the `b_0`/`b_1` distinction in the example.)
| /// Returns basic blocks in a reverse postorder. | ||
| /// | ||
| /// See [`traversal::reverse_postorder`]'s docs to learn what is preorder traversal. | ||
| /// See [`traversal::reverse_postorder`]'s docs to learn what is postorder traversal. |
Contributor
There was a problem hiding this comment.
Grammatical nit (preexisting):
Suggested change
| /// See [`traversal::reverse_postorder`]'s docs to learn what is postorder traversal. | |
| /// See [`traversal::reverse_postorder`]'s docs to learn what postorder traversal is. |
Alternatively:
Suggested change
| /// See [`traversal::reverse_postorder`]'s docs to learn what is postorder traversal. | |
| /// See [`traversal::reverse_postorder`]'s docs for an explanation of postorder traversal. |
Might not be worth fixing, though, at least in this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly in the examples in
initialized.rs. In particular, theEverInitializedPlacesexample currently doesn't cover how it's initialization sites that are tracked, rather than local variables (that's theb_0/b_1distinction in the example.)r? @cjgillot