Add missing safety doc for CString::from_vec_unchecked and async_drop_in_place#153384
Open
hxuhack wants to merge 7 commits intorust-lang:mainfrom
Open
Add missing safety doc for CString::from_vec_unchecked and async_drop_in_place#153384hxuhack wants to merge 7 commits intorust-lang:mainfrom
hxuhack wants to merge 7 commits intorust-lang:mainfrom
Conversation
Collaborator
|
r? @joboet rustbot has assigned @joboet. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
asder8215
reviewed
Mar 5, 2026
asder8215
reviewed
Mar 5, 2026
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
Clarify safety concerns in async_drop_in_place documentation.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing safety documentation for two unsafe APIs:
CString::from_vec_unchecked– # Safety: the caller must ensurevcontains no NUL bytes in its contents.async_drop_in_place– # Safety: see [ptr::drop_in_place] for safety requirements.