library: std: fs: skip tests on Hermit#153294
Open
Gelbpunkt wants to merge 1 commit intorust-lang:mainfrom
Open
library: std: fs: skip tests on Hermit#153294Gelbpunkt wants to merge 1 commit intorust-lang:mainfrom
Gelbpunkt wants to merge 1 commit intorust-lang:mainfrom
Conversation
The tests make use of symlinks, which are not currently supported on Hermit.
Collaborator
|
r? @joboet rustbot has assigned @joboet. Use Why was this reviewer chosen?The reviewer was selected based on:
|
tgross35
reviewed
Mar 4, 2026
Comment on lines
32
to
43
| #[cfg(all( | ||
| test, | ||
| not(any( | ||
| target_os = "emscripten", | ||
| target_os = "wasi", | ||
| target_env = "sgx", | ||
| target_os = "xous", | ||
| target_os = "trusty", | ||
| target_os = "hermit", | ||
| )) | ||
| ))] | ||
| mod tests; |
Contributor
There was a problem hiding this comment.
It would be good to have a comment about why they're skipped
Contributor
|
If symlinks are a problem but everything else works, could only the relevant tests be skipped? Or moved into an inline module to make that easier. Cc target maintainers @stlankes @mkroening |
Contributor
Author
That sounds reasonable. I'll update the PR to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests make use of symlinks, which are not currently supported on Hermit.