Tidy: disallow TODO in other in-tree projects by reddevilmidzy · Pull Request #153166 · rust-lang/rust

reddevilmidzy · 2026-02-27T04:08:47Z

Fixes: #152280
MCP: rust-lang/compiler-team#963

TODO

Add ci check to cg_clif: Add TODO checker to cg_clif rustc_codegen_cranelift#1632
Add ci check to cg_gcc: Add TODO checker to cg_gcc rustc_codegen_gcc#861

r? lcnr

src/tools/tidy/src/alphabetical.rs

compiler/rustc_codegen_gcc/tools/generate_intrinsics.py

src/tools/tidy/src/unit_tests.rs

rustbot · 2026-02-27T06:21:16Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

bjorn3 · 2026-02-27T07:28:01Z

Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.

jieyouxu · 2026-02-27T09:46:55Z

Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.

I would suggest not running full tidy against the cg_* subtrees yeah.

Also, doesn't rust-lang/compiler-team#963 only say TODO -> FIXME? Not other tidy checks? I do not think we should be enforcing other tidy rules for the cg_* subtrees.

reddevilmidzy · 2026-02-27T10:56:56Z

Ah, I overinterpreted it — my mistake. Thanks for the clarification. I’ll update it accordingly.

reddevilmidzy

I've also added a TODO check to the CI for cg_* (rust-lang/rustc_codegen_cranelift#1632, rust-lang/rustc_codegen_gcc#861).

View changes since this review

reddevilmidzy · 2026-03-07T11:53:15Z

src/tools/tidy/src/codegen.rs

I tried to add cg_* checks to style.rs, which checks TODOs in tidy, but since it also checks other things besides TODOs, I separated it into codegen.rs.

reddevilmidzy · 2026-03-07T12:15:15Z

compiler/rustc_session/src/parse.rs

    }
 }

-// todo: this function now accepts `Session` instead of `ParseSess` and should be relocated


lowercase 👀

lcnr · 2026-03-09T06:35:08Z

compiler/rustc_codegen_gcc/src/type_.rs

            .enumerate()
            .map(|(index, field)| {
-                self.context.new_field(None, *field, format!("field{}_TODO", index))
+                self.context.new_field(None, *field, format!("field{}_FIXME", index))


is that fine?

Oh, I'll check this again. Thank you

I changed TODO to FIXME and tested it and it worked.

rust-lang/rustc_codegen_gcc@d82d242

cc: @antoyo

Yes, this should be OK.

lcnr · 2026-03-09T06:37:52Z

src/tools/tidy/src/style.rs

+        let is_codegen_tidy_file = file.ends_with(codegen_file);
+        if is_codegen_tidy_file {
+            return;
+        }


a035848#diff-2877cff958f18d248fbdb0e5f924a453e3911e7e8340139125911d3bdd8e5a62R49-R53

I'm using the "TODO" character here and top line, this is the part that was added to skip TODO check

reddevilmidzy commented Feb 27, 2026

View reviewed changes

src/tools/tidy/src/alphabetical.rs Outdated Show resolved Hide resolved

compiler/rustc_codegen_gcc/tools/generate_intrinsics.py Outdated Show resolved Hide resolved

src/tools/tidy/src/unit_tests.rs Outdated Show resolved Hide resolved

rustbot assigned lcnr Feb 27, 2026

reddevilmidzy marked this pull request as ready for review February 27, 2026 06:21

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 27, 2026

reddevilmidzy marked this pull request as draft February 27, 2026 10:58

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2026

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the codegen-tidy branch from 8af1d2e to 474d3e6 Compare March 6, 2026 06:27

This was referenced Mar 7, 2026

Add TODO checker to cg_clif rust-lang/rustc_codegen_cranelift#1632

Draft

Add TODO checker to cg_gcc rust-lang/rustc_codegen_gcc#861

Draft

rust-cloud-vms bot force-pushed the codegen-tidy branch from 474d3e6 to ac17a97 Compare March 7, 2026 11:11

Change TODO in compiler to FIXME

50db919

rust-cloud-vms bot force-pushed the codegen-tidy branch 2 times, most recently from 89a1cb9 to 2617d54 Compare March 7, 2026 12:39

reddevilmidzy changed the title ~~Allow tidy check in codegen~~ Tidy: disallow TODO in other in-tree projects Mar 7, 2026

reddevilmidzy commented Mar 7, 2026

View reviewed changes

reddevilmidzy marked this pull request as ready for review March 7, 2026 12:50

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 7, 2026

This comment has been minimized.

Sign in to view

reddevilmidzy added 2 commits March 7, 2026 14:38

bless ui tests

b91901d

Add codegen tidy check enforcing FIXME over TODO

a035848

rust-cloud-vms bot force-pushed the codegen-tidy branch from 2617d54 to a035848 Compare March 7, 2026 14:38

lcnr reviewed Mar 9, 2026

View reviewed changes

Uh oh!

Conversation

reddevilmidzy commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Feb 27, 2026

Uh oh!

bjorn3 commented Feb 27, 2026

Uh oh!

jieyouxu commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reddevilmidzy commented Feb 27, 2026

Uh oh!

This comment has been minimized.

reddevilmidzy left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

reddevilmidzy commented Feb 27, 2026 •

edited

Loading

jieyouxu commented Feb 27, 2026 •

edited

Loading

reddevilmidzy left a comment •

edited by rustbot

Loading