r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

r? rustdoc
This works, but maybe there is a better solution?

Aren't relative paths working instead of adding JS in docs?

Aren't relative paths working instead of adding JS in docs?

See #151170.
On local, we need to do ../../std/primitive.slice.html#method.concat

But for this to work on the doc website, we need to do ../std/primitive.slice.html#method.concat. Otherwise, we have a file not found/page doesn't exist error either on website or local.

On local it's doc/std/index.html and on remote it's nightly/std/index.html. Seems to be the same, no?

On local it's doc/std/index.html and on remote it's nightly/std/index.html. Seems to be the same, no?

When I go on the website and inspect the href for the [T]::concat link in:
https://doc.rust-lang.org/alloc/slice/trait.Concat.html
it shows:

Changing this to ../../std/primitive.slice.html#method.concat will link to the right page while changing this to ../std/primitive.slice.html#method.concat will result in a page not found error. On local, when I build the docs through ./x doc --stage 1 library --open, it's the vice versa.

In any case, I think it should be fixed in rustdoc and not in the docs directly.

Got it, I'll close this PR for now. Is there a place I should take a look in librustdoc to attempt fixing this?

There was a discussion about this in #152917. That might be a good start.