Skip to content

rustc_public: add vtable_entries() to TraitRef#152669

Open
makai410 wants to merge 1 commit intorust-lang:mainfrom
makai410:rpub-vtable
Open

rustc_public: add vtable_entries() to TraitRef#152669
makai410 wants to merge 1 commit intorust-lang:mainfrom
makai410:rpub-vtable

Conversation

@makai410
Copy link
Member

@makai410 makai410 commented Feb 15, 2026

@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2026

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 15, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2026

r? @celinval

rustbot has assigned @celinval.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: project-stable-mir
  • project-stable-mir expanded to celinval, makai410, oli-obk, scottmcm
  • Random selection from celinval, scottmcm

celinval
celinval reviewed Feb 27, 2026
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! To close the issue, we still need to add an API that takes the index and return the respective definition. Do you mind adding it to this CR? Thanks!

View changes since this review

@makai410
Copy link
Member Author

makai410 commented Mar 10, 2026

Awesome! To close the issue, we still need to add an API that takes the index and return the respective definition. Do you mind adding it to this CR? Thanks!

View changes since this review

We could use vtable_entries().get(idx), right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@celinval celinval celinval left review comments

Assignees

@celinval celinval

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add vtable info

3 participants

@makai410 @rustbot @celinval