Skip to content

Rollup of 2 pull requests#152314

Merged
rust-bors[bot] merged 5 commits intorust-lang:mainfrom
Zalathar:rollup-4WUNK14
Feb 8, 2026
Merged

Rollup of 2 pull requests#152314
rust-bors[bot] merged 5 commits intorust-lang:mainfrom
Zalathar:rollup-4WUNK14

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Feb 8, 2026

Successful merges:

r? @ghost

Create a similar rollup

Zalathar and others added 5 commits February 7, 2026 23:41
… r=Urgau

Remove `rustdoc` adhoc group

With rust-lang/triagebot#2273, reviewers can now tell triagebot to opt them out of being assigned through a given team, so that `r? <team>` does not consider them if they don't want to.

That means that we can now finally get rid of adhoc groups that correspond to actual Rust teams. I wanted to start with a smaller team than `t-compiler` to test this, so I started with `rustdoc`, which was the smallest team that I found an adhoc group for.

Currently, the `rustdoc` team contains the following members:
- aDotInTheVoid
- GuillaumeGomez
- notriddle
- fmease
- camelid
- Manishearth
- Urgau
- lolbinarycat
- yotamofek

Only three of those were previously assignable through `r? rustdoc`. So to reproduce the previous state, I will run `as <username> work set-team-rotation-mode rustdoc off` for the remaining members of the `rustdoc` team before this is merged.

If more people from `t-rustdoc` want to join the review rotation, they can send [triagebot](https://rust-lang.zulipchat.com/#narrow/dm/261224-triagebot) a DM with `work set-team-rotation-mode rustdoc on`.

CC @rust-lang/rustdoc
…cote

Avoid a bogus THIR span for `let x = offset_of!(..)`

The code that creates spans for THIR `let` statements was doing span endpoint manipulation without checking for inclusion/context, resulting in bogus spans observed in rust-lang#151693.

The incorrect spans are easiest to observe with `-Zunpretty=thir-tree`, but they also cause strange user-facing diagnostics for irrefutable let-else.
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Feb 8, 2026
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 8, 2026
@Zalathar
Copy link
Member Author

Zalathar commented Feb 8, 2026

Rollup of everything.

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 8, 2026

📌 Commit 1992e71 has been approved by Zalathar

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2026
@rust-bors rust-bors bot mentioned this pull request Feb 8, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 8, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 8, 2026

☀️ Test successful - CI
Approved by: Zalathar
Duration: 3h 8m 6s
Pushing 08a4ce5 to main...

@rust-bors rust-bors bot merged commit 08a4ce5 into rust-lang:main Feb 8, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 8, 2026
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#152284 Avoid a bogus THIR span for let x = offset_of!(..) 013a6f86dad4460205705dae13dd0a89ff7a163d (link)
#152310 Remove rustdoc adhoc group 371c9aed4da9ec5009726fbed09c9d1c132b8173 (link)

previous master: c69e1a04db

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c69e1a0 (parent) -> 08a4ce5 (this PR)

Test differences

Show 4 test diffs

Stage 1

  • [ui] tests/ui/span/let-offset-of.rs: [missing] -> pass (J0)

Stage 2

  • [ui] tests/ui/span/let-offset-of.rs: [missing] -> pass (J1)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 08a4ce529f4ea17ad1c0fa2e39ca1f5e7cd047b6 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-llvm-21-2: 1h 55m -> 1h 28m (-23.9%)
  2. x86_64-gnu-llvm-21-1: 1h 29m -> 1h 12m (-18.6%)
  3. dist-x86_64-apple: 1h 49m -> 2h 9m (+17.9%)
  4. aarch64-gnu: 2h 32m -> 2h 10m (-14.4%)
  5. x86_64-gnu-llvm-21-3: 2h 10m -> 1h 52m (-13.9%)
  6. dist-aarch64-apple: 1h 57m -> 1h 45m (-9.7%)
  7. x86_64-gnu-llvm-20-2: 1h 29m -> 1h 37m (+9.3%)
  8. x86_64-msvc-ext2: 1h 43m -> 1h 35m (-8.4%)
  9. i686-gnu-nopt-1: 2h 9m -> 2h 19m (+7.9%)
  10. x86_64-gnu-nopt: 2h 12m -> 2h 23m (+7.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (08a4ce5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
4.8% [4.8%, 4.8%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.8% [4.8%, 4.8%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.659s -> 476.152s (0.31%)
Artifact size: 397.96 MiB -> 397.96 MiB (-0.00%)

@Zalathar Zalathar deleted the rollup-4WUNK14 branch February 8, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants