Fix ICE when using Iterator in const contexts#152242
Open
xonx4l wants to merge 4 commits intorust-lang:mainfrom
Open
Fix ICE when using Iterator in const contexts#152242xonx4l wants to merge 4 commits intorust-lang:mainfrom
xonx4l wants to merge 4 commits intorust-lang:mainfrom
Conversation
Collaborator
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
cc @lcnr |
Member
|
i appreciate the effort, but I am pretty sure this is just wrong.... we shouldn't make every type implement iterator |
Member
|
@rustbot author |
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Contributor
Author
|
@fee1-dead Sorry I was a bit busy. You're right . I was thinking too broad . I Think what if we return an error instead of a success that might work . what you say? Thanks for the feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR built-in candidates are implemented for Iterator and FusedIterator to resolve the issue in #151901
-> implement built-in candidates for Iterator and FusedIterator.
-> Added and blessed test for the built-in candidates implementation.