Update openmp/offload to new LLVM-22 build setup#152011
Update openmp/offload to new LLVM-22 build setup#152011ZuseZ4 wants to merge 2 commits intorust-lang:mainfrom
Conversation
| .profile(profile) | ||
| .env("LLVM_CONFIG_REAL", &host_llvm_config) | ||
| .define("LLVM_ENABLE_ASSERTIONS", "ON") | ||
| .define("LLVM_ENABLE_RUNTIMES", "openmp;offload") |
There was a problem hiding this comment.
offload won't work targeting a GPU. I made a change to silently accept this upstream but I don't think you're on that.
There was a problem hiding this comment.
I tried it, but I don't think it's worth backporting. Fwiw this config works locally without your LLVM PR.
This comment has been minimized.
This comment has been minimized.
1a6f0e4 to
a85f0aa
Compare
This comment has been minimized.
This comment has been minimized.
a85f0aa to
3becbd2
Compare
This comment has been minimized.
This comment has been minimized.
|
So, with the vendored llvm patch (it's backport will be in the next Release candidate in 2 weeks) I can now locally build libc-for-gpu, which is the last piece that I had to postpone so far. Now it finishes the llvm and ompoffload/libc build steps. |
This comment has been minimized.
This comment has been minimized.
3becbd2 to
4e818c9
Compare
|
@jieyouxu I rebased one the latest llvm, which had another backport for us. The problem is simply, that we want to compile libc-for-gpu with a nvptx/amdgcn as targets. This runs into the following assertion: I also tried to hardcode it as I experimented a bit with setting |
|
(I'll try to take a look this weekend) |
I'm just testing the libc-gpu build as well, will push an update later.
cc @jhuber6 Does that look like what you have in mind? I'm running all 3 reusing the same output directory (out_dir). I know I shouldn't do that for higher level differences like llvm vs omp/offload builds, but when just having different targets it seems to work fine (?)
cc @Sa4dUs can you test this please for nvidia?
blocked-on LLVM rc3 in #152428, which should include: llvm/llvm-project#179375blocked on LLVM RC-final, which should include llvm/llvm-project#181048