Skip to content

Stabilise EULER_GAMMA and GOLDEN_RATIO constants for f32 and f64. #151164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bjoernager wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stabilise EULER_GAMMA and GOLDEN_RATIO constants for f32 and f64. #151164

bjoernager wants to merge 1 commit into from
+14 −16

Conversation

@bjoernager
Copy link
Contributor

@bjoernager bjoernager commented Jan 15, 2026 •
edited
Loading

Tracking issue: #146939

This PR renames the EGAMMA and PHI constants to EULER_GAMMA and GOLDEN_RATIO – respectively – and stabilises them under these names for f32 and f64:

// core::f16::consts

pub const GOLDEN_RATIO: f16;

pub const EULER_GAMMA: f16;

// core::f32::consts

pub const GOLDEN_RATIO: f32;

pub const EULER_GAMMA: f32;

// core::f64::consts

pub const GOLDEN_RATIO: f64;

pub const EULER_GAMMA: f64;

// core::f128::consts

pub const GOLDEN_RATIO: f128;

pub const EULER_GAMMA: f128;

The feature gate for the stabilised items is also changed to euler_gamma_golden_ratio.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 15, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 15, 2026

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@bjoernager bjoernager mentioned this pull request Jan 15, 2026
Open
14 tasks
@bjoernager
Copy link
Contributor Author

bjoernager commented Jan 15, 2026

@rustbot label +T-libs-api -T-libs

r? libs-api

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 15, 2026
@rustbot rustbot assigned BurntSushi and unassigned jhpratt Jan 15, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjoernager bjoernager force-pushed the euler-gamma-golden-ratio branch from 8f7d4ee to 7f9237d Compare January 15, 2026 15:04
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjoernager bjoernager force-pushed the euler-gamma-golden-ratio branch from 7f9237d to 6cd4359 Compare January 15, 2026 15:20
traviscross
traviscross approved these changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@traviscross traviscross left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

View changes since this review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@traviscross traviscross traviscross approved these changes

Assignees

@BurntSushi BurntSushi

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bjoernager @rustbot @rust-log-analyzer @traviscross @BurntSushi @jhpratt