-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Tidying up tests/ui/issues 15 tests [8/N]
#151159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tests/ui/issues 15 tests [8/N]
This comment has been minimized.
This comment has been minimized.
|
hmm, I don't know why rustbot didn't leave this comment this time. |
Maybe rustbot is busy after new year holidays and overlooked that one |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after move this tests and squash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly more like a mismatched types to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is generics
|
@bors delegate+ |
|
✌️ @reddevilmidzy, you can now approve this pull request! If @Kivooeo told you to " |
merge privacy/privacy-sanity-2 with privacy/privacy-sanity.rs Add comment to generics/type-args-on-module-in-bound.rs Add comment to array-slice-vec/closure-in-array-eln.rs Add comment to array-slice-vec/return-in-array-len.rs Merge for-loop-while/break-outside-loop-2.rs with for-loop-while/break-outside-loop.rs Add comment to macros/column-macro-collision.rs Add comment to privacy/private-extern-fn-visibility.rs Add comment to mismatched_types/vec-hashset-type-mismatch.rs Merge std-sync-right-kind-impls-2.rs with std-sync-right-kind-impls.rs Add comment to array-slice-vec/slice-of-multi-ref.rs Add comment to mismatched_types\vec-hashset-type-mismatch.rs Add comment to derives/derive-hygiene-struct-builder.rs Add comment to label/undeclared-label-span.rs Add comment to label\undeclared-label-span.rs Add comment to mismatched_types/array-repeat-unit-struct.rs
|
I've applied your suggestion. thank you:) @bors r=Kivooeo |
Note
Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge.
part of #133895
There are some tests named {xxx}-2, which are meant to be merged with {xxx}.
r? Kivooeo