Skip to content

Conversation

@reddevilmidzy
Copy link
Member

Note

Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge.

part of #133895

There are some tests named {xxx}-2, which are meant to be merged with {xxx}.

r? Kivooeo

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 15, 2026
@reddevilmidzy reddevilmidzy changed the title Tidying up tests/ui/issues 15 tests [8/N] Tidying up tests/ui/issues 15 tests [8/N] Jan 15, 2026
@rust-log-analyzer

This comment has been minimized.

@reddevilmidzy
Copy link
Member Author

hmm, I don't know why rustbot didn't leave this comment this time.

@Kivooeo
Copy link
Member

Kivooeo commented Jan 15, 2026

hmm, I don't know why rustbot didn't leave this comment this time.

Maybe rustbot is busy after new year holidays and overlooked that one

@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@Kivooeo Kivooeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after move this tests and squash

View changes since this review

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly more like a mismatched types to me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is generics

@Kivooeo
Copy link
Member

Kivooeo commented Jan 15, 2026

@bors delegate+

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 15, 2026

✌️ @reddevilmidzy, you can now approve this pull request!

If @Kivooeo told you to "r=me" after making some further change, then please make that change and post @bors r=Kivooeo.

merge privacy/privacy-sanity-2 with privacy/privacy-sanity.rs

Add comment to generics/type-args-on-module-in-bound.rs

Add comment to array-slice-vec/closure-in-array-eln.rs

Add comment to array-slice-vec/return-in-array-len.rs

Merge for-loop-while/break-outside-loop-2.rs with
for-loop-while/break-outside-loop.rs

Add comment to macros/column-macro-collision.rs

Add comment to privacy/private-extern-fn-visibility.rs

Add comment to mismatched_types/vec-hashset-type-mismatch.rs

Merge std-sync-right-kind-impls-2.rs with std-sync-right-kind-impls.rs

Add comment to array-slice-vec/slice-of-multi-ref.rs

Add comment to mismatched_types\vec-hashset-type-mismatch.rs

Add comment to derives/derive-hygiene-struct-builder.rs

Add comment to label/undeclared-label-span.rs

Add comment to label\undeclared-label-span.rs

Add comment to mismatched_types/array-repeat-unit-struct.rs
@reddevilmidzy
Copy link
Member Author

I've applied your suggestion. thank you:)

@bors r=Kivooeo

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 15, 2026

📌 Commit 77b2a19 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants