-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Compile bootstrap with -Zbinary-dep-depinfo #151114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
In cg_clif's test framework it is possible for the standard library to change in an ABI incompatible way without the rustc binary changing. In that case rustc wouldn't rebuild all bootstrap dependencies, causing compilation to fail. Passing -Zbinary-dep-depinfo fixes this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this added to bootstrap, specifically? Wouldn't the situation that you describe affect pretty much any code that you compile with the ABI-incompatible stdlib? 🤔
| args += ["-Zwarnings"] | ||
| env["CARGO_BUILD_WARNINGS"] = "deny" | ||
|
|
||
| env["RUSTFLAGS"] += " -Zbinary-dep-depinfo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a comment that explains this?
|
r? Kobzol (since you're already looking at it) |
|
|
In cg_clif's test framework it is possible for the standard library to change in an ABI incompatible way without the rustc binary changing. In that case rustc wouldn't rebuild all bootstrap dependencies, causing compilation to fail. Passing -Zbinary-dep-depinfo fixes this.