Skip to content

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jan 14, 2026

In cg_clif's test framework it is possible for the standard library to change in an ABI incompatible way without the rustc binary changing. In that case rustc wouldn't rebuild all bootstrap dependencies, causing compilation to fail. Passing -Zbinary-dep-depinfo fixes this.

In cg_clif's test framework it is possible for the standard library to
change in an ABI incompatible way without the rustc binary changing. In
that case rustc wouldn't rebuild all bootstrap dependencies, causing
compilation to fail. Passing -Zbinary-dep-depinfo fixes this.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 14, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this added to bootstrap, specifically? Wouldn't the situation that you describe affect pretty much any code that you compile with the ABI-incompatible stdlib? 🤔

View changes since this review

args += ["-Zwarnings"]
env["CARGO_BUILD_WARNINGS"] = "deny"

env["RUSTFLAGS"] += " -Zbinary-dep-depinfo"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a comment that explains this?

@jieyouxu
Copy link
Member

r? Kobzol (since you're already looking at it)

@rustbot rustbot assigned Kobzol and unassigned jieyouxu Jan 14, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2026

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants