Skip to content

std: implement sleep_until on Apple platforms #151004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joboet wants to merge 3 commits into
base: main
Choose a base branch
from
Open

std: implement sleep_until on Apple platforms #151004

joboet wants to merge 3 commits into from

Conversation

@joboet
Copy link
Member

@joboet joboet commented Jan 12, 2026 •
edited by madsmtm
Loading

On Apple platforms, nanosleep is internally implemented using mach_wait_until, a function that waits until a deadline specified in terms of mach_absolute_time. Since mach_wait_until is public1, we can use it to implement sleep_until by converting Instants (which are measured against CLOCK_UPTIME_RAW, which is equivalent to mach_absolute_time) into mach_absolute_time values.

Related tracking issue: #113752

Footnotes

  1. It's badly documented, but it's defined in the same header as mach_absolute_time, which std used to use for Instant before time: use clock_gettime on macos #116238. ↩

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2026

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@joboet joboet mentioned this pull request Jan 12, 2026
Open
8 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2026

The Miri subtree was changed

cc @rust-lang/miri

ChrisDenton
ChrisDenton reviewed Jan 12, 2026
View reviewed changes
@JayanAXHF JayanAXHF added O-macos Operating system: macOS S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2026
@madsmtm madsmtm added O-apple Operating system: Apple / Darwin (macOS, iOS, tvOS, visionOS, watchOS) and removed O-macos Operating system: macOS labels Jan 13, 2026
madsmtm
madsmtm reviewed Jan 13, 2026
View reviewed changes
madsmtm
madsmtm reviewed Jan 13, 2026
View reviewed changes
@joboet joboet force-pushed the apple-sleep-until branch from 65aa2b0 to d9189bf Compare January 13, 2026 09:45
@rustbot rustbot added the O-unix Operating system: Unix-like label Jan 13, 2026
@joboet joboet added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 13, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@joboet joboet force-pushed the apple-sleep-until branch from d9189bf to ced9de5 Compare January 13, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisDenton ChrisDenton ChrisDenton left review comments

@madsmtm madsmtm madsmtm approved these changes

Assignees

@ChrisDenton ChrisDenton

Labels

O-apple Operating system: Apple / Darwin (macOS, iOS, tvOS, visionOS, watchOS) O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joboet @rustbot @rust-log-analyzer @ChrisDenton @madsmtm @JayanAXHF