Added mGCA related tests #150886
Open
Added mGCA related tests #150886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
rustbot has assigned @JonathanBrouwer. Use |
9327183 to
5218021
Compare
Kivooeo
reviewed
Jan 9, 2026
Member
|
r? BoxyUwU |
28c9775 to
51da0b7
Compare
reddevilmidzy
commented
Jan 10, 2026
Comment on lines
+14
to
+25
| impl<T: Abc> A for T { | ||
| #[type_const] | ||
| const VALUE: usize = 0; | ||
| } | ||
|
|
||
| trait S<const K: usize> {} | ||
|
|
||
| trait Handler<T: Abc> | ||
| where | ||
| (): S<{ <T as A>::VALUE }>, | ||
| { | ||
| } |
Member
Author
There was a problem hiding this comment.
ICE was also reproduced in code like this.
Member
Author
|
Thanks for your quick check! I'll add more tests to address the resolved mGCA ICE issue. @rustbot author |
Member
Author
Member
I can't reproduce it on playground |
Member
Author
If I pull the latest main locally and then run this test, I get an ICE. //! regression test for <https://github.com/rust-lang/rust/issues/138226>
//! and <https://github.com/rust-lang/rust/issues/138227>
#![expect(incomplete_features)]
#![feature(min_generic_const_args)]
#![feature(inherent_associated_types)]
#![allow(dead_code)]
struct Foo<A, B>(A, B);
impl<A, B> Foo<A, B> {
#[type_const]
const VALUE: usize = 4;
fn foo() {
let _ = [5; Self::VALUE];
}
}
struct Bar<const N: usize>;
impl<const N: usize> Bar<N> {
#[type_const]
const VALUE: usize = 4;
fn bar() {
let _ = [0; Self::VALUE];
}
}
fn main() {}Backtrace
|
Member
Author
|
It seems like it wasn't reflected in playground nightly because it was a very recent work. |
Member
Seems like it, would be nice if you could bisect it (I would be able to do this myself, but only little bit later) |
Member
Author
Failed to find with bisect rustc, I'll wait a bit and try again. |
51da0b7 to
66c81b9
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
66c81b9 to
b88fa37
Compare
Collaborator
|
This PR changes a file inside |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
I don't know why ICE occurred when the test code was in 
|
b88fa37 to
73f03e6
Compare
This comment has been minimized.
This comment has been minimized.
73f03e6 to
0474916
Compare
Member
Author
|
Added tests for five resolved issues and four crash tests. @rustbot ready |
Member
Author
|
I guessed it was related to debug assert since ICE is reproduced in rustc 1.94.0-dev but not in rustc 1.94.0-nightly. So, to verify that the ICE currently occurring in rustc-dev was indeed eliminated in nightly-2025-05-05, I checked out the last commit from 2025-05-05 and ran |
BoxyUwU
reviewed
Jan 13, 2026
| @@ -0,0 +1,14 @@ | |||
| //! regression test for <https://github.com/rust-lang/rust/issues/143506> | |||
Member
There was a problem hiding this comment.
There are still ways to reproduce this ICE unfortunately, can you remove this test.
BoxyUwU
reviewed
Jan 13, 2026
| #![feature(min_generic_const_args)] | ||
|
|
||
| fn foo<T>() { | ||
| [0; size_of::<*mut T>()]; |
Member
There was a problem hiding this comment.
can you add a second line for [0; const { size_of::<*mut T>() }]
BoxyUwU
reviewed
Jan 13, 2026
| @@ -0,0 +1,11 @@ | |||
| //! regression test for <https://github.com/rust-lang/rust/issues/143358> | |||
Member
There was a problem hiding this comment.
I think this bug was only ever reproducible via generic_const_exprs as it relied on anon consts inheriting generics from parent defs (and then those parent defs being broken defids from mGCA).
cc #148843
I would prefer to remove this test but still close the issue as I don't think we get much value from having more test coverage for generic_const_exprs
BoxyUwU
reviewed
Jan 13, 2026
| @@ -0,0 +1,26 @@ | |||
| //! regression test for <https://github.com/rust-lang/rust/issues/139259> | |||
Member
There was a problem hiding this comment.
This still ICEs can you remove this test
0474916 to
6166b61
Compare
Member
Author
|
thank you for the review. I've deleted the tests you mentioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add regression tests for subsequent mGCA tasks
edit:
resolve: #147415
tests\ui\const-generics\mgca\size-of-generic-ptr-in-array-len.rsresolve: #141014
tests\ui\const-generics\mgca\assoc-const-projection-in-bound.rsand crashes: 138226, 138226-2, 149809, 150960