Skip to content

Cleanup debuginfo_compression unstable flag #150577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Jan 2, 2026
Merged

Cleanup debuginfo_compression unstable flag #150577

bors merged 1 commit into from
Jan 2, 2026
+1 −5

Conversation

@wesleywiser
Copy link
Member

@wesleywiser wesleywiser commented Jan 2, 2026 •
edited by rustbot
Loading

It isn't necessary to declare the option as a top-level flag when it is accessible from unstable_opts.

cc #120953

@wesleywiser
Cleanup debuginfo_compression unstable flag
f74896f 
It isn't necessary to declare the option as a top-level flag when
it is accessible from `unstable_opts`.
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 2, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2026

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@mati865
Copy link
Member

mati865 commented Jan 2, 2026

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 2, 2026

📌 Commit f74896f has been approved by mati865

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2026
@bors
Copy link
Collaborator

bors commented Jan 2, 2026

⌛ Testing commit f74896f with merge bf6b5b9...

@bors
Copy link
Collaborator

bors commented Jan 2, 2026

☀️ Test successful - checks-actions
Approved by: mati865
Pushing bf6b5b9 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 2, 2026
@bors bors merged commit bf6b5b9 into rust-lang:main Jan 2, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 1b43252 (parent) -> bf6b5b9 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard bf6b5b9dedd3e95a2867555e3d780fc3ece11ff6 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3575.4s -> 4637.2s (+29.7%)
  2. x86_64-gnu-gcc: 2770.4s -> 3492.2s (+26.1%)
  3. dist-aarch64-apple: 6358.0s -> 7415.9s (+16.6%)
  4. i686-gnu-nopt-1: 7122.5s -> 8111.1s (+13.9%)
  5. test-various: 6779.5s -> 7712.0s (+13.8%)
  6. x86_64-gnu-stable: 8158.6s -> 9170.5s (+12.4%)
  7. dist-x86_64-apple: 8694.5s -> 7628.1s (-12.3%)
  8. aarch64-gnu-llvm-20-2: 2775.3s -> 3112.5s (+12.1%)
  9. i686-gnu-2: 5302.3s -> 5899.4s (+11.3%)
  10. i686-gnu-1: 7394.5s -> 8219.1s (+11.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Jan 2, 2026

Finished benchmarking commit (bf6b5b9): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.6% [-0.6%, -0.6%] 1

Cycles

Results (secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.4% [2.3%, 2.5%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.736s -> 473.964s (0.26%)
Artifact size: 390.80 MiB -> 390.78 MiB (-0.00%)

@wesleywiser wesleywiser mentioned this pull request Jan 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mati865 mati865

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@wesleywiser @rustbot @mati865 @bors @rust-timer