-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Rollup of 4 pull requests #150575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #150575
Conversation
Adds a test for nested proc-macro calls where the inner macro returns an empty TokenStream. This previously caused an ICE in rustc_resolve.
Since they became alumni and don't want to receive pings anymore.
…e-cargo}` to `compiler` So that I don't become the only automatically-assigned reviewer due to weighting reasons.
So that there's `n > 1` selection pool in case one of the eligible reviewers go off rotation.
…ethercote Tweak wording of diff marker diagnostic
…thercote test and document that `proc_macro::Ident` is NFC-normalized Previously, this was not tested at all and the test suite would pass even when replacing the `normalize_and_validate_ident` implementation with a `panic!`.
Add regression test for issue rust-lang#99173 Close rust-lang#99173. Adds a regression test for rust-lang#99173, which was an ICE that occurred when a proc-macro generated code that invoked another proc-macro returning an empty `TokenStream`.
Update triagebot config for `compiler-errors`, `tests/{run-make,run-make-cargo}` and `fallback` adhoc_group
- Commit 1: Updates triagebot entries for `compiler-errors` (context: rust-lang/team#2205)
- Commit 2: Expand `tests/{run-make,run-make-cargo}` reviewer pool to the `compiler` `adhoc_group` instead of just me for weighting reasons, so I don't become the sole assigned reviewer even when I'm off rotation.
- Commit 3: Add myself to `fallback` adhoc_group so there's `n > 1` pool there, in case one of the reviewers go off rotation.
|
@bors r+ rollup=never p=5 |
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: fcd630976c In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing fcd6309 (parent) -> 056908d (this PR) Test differencesShow 4 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 056908d7f44ab901ae6573cf2d9c1d8b166ed1c5 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (056908d): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -10.5%, secondary -16.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 475.254s -> 474.6s (-0.14%) |
Successful merges:
proc_macro::Identis NFC-normalized #150431 (test and document thatproc_macro::Identis NFC-normalized)compiler-errors,tests/{run-make,run-make-cargo}andfallbackadhoc_group #150568 (Update triagebot config forcompiler-errors,tests/{run-make,run-make-cargo}andfallbackadhoc_group)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup