Skip to content

Rollup of 4 pull requests #150435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 9 commits into from
Dec 27, 2025
Merged

Rollup of 4 pull requests #150435

bors merged 9 commits into from
Dec 27, 2025

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Dec 27, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

heathdutton and others added 9 commits December 25, 2025 12:31
@heathdutton
rustdoc: fix duplicate Re-exports sections
b2f19ea 
When a module contains both `pub extern crate` and `pub use` items,
they were being rendered under two separate "Re-exports" section
headers instead of one. This happened because the code iterated over
each ItemType separately and rendered a section header for each,
even though both ExternCrate and Import map to the same ItemSection.

This fix tracks the current section and only renders a new header
when the section actually changes, consolidating items that belong
to the same section under a single header.
@BioTomateHP
Update hir.rs: fix typo, conform to max_width
09f57eb
@crescentrose
Document default SOCK_CLOEXEC flag on new UnixStream
106e88e 
Currently, the `std::os::unix::net::UnixStream` docs do not specify that
the SOCK_CLOEXEC flag is set on new sockets. This commit adds a note
clarifying that, in line with the note abuot the `MSG_NOSIGNAL` flag.
@crescentrose
fix late night markdown
ee9db30
@Noratrieb
Improve missing core error for tier 3 targets
7898df4 
Tier 3 targets can't be installed via rustup, so don't recommend that.
Additionally, do recommend build-std on stable because it's the
recommended way to use these targets, people should switch to nightly.
@JonathanBrouwer
Rollup merge of rust-lang#150362 - heathdutton:fix-rustdoc-duplicate-…
af77f2d 
…reexports-150211, r=notriddle

rustdoc: fix duplicate Re-exports sections

Fixes rust-lang#150211

When a module contains both `pub extern crate` and `pub use` items, they were being rendered under two separate "Re-exports" section headers instead of one.

This fix tracks the current section and only renders a new header when the section actually changes, consolidating items that belong to the same section under a single header.
@JonathanBrouwer
Rollup merge of rust-lang#150397 - BioTomateHP:patch-1, r=petrochenkov
adbcef3 
Update hir.rs: fix typo ("aligement" -> "alignment"), conform to max_width
@JonathanBrouwer
Rollup merge of rust-lang#150410 - crescentrose:document-socket-cloex…
e2e271b 
…ec, r=ChrisDenton

Document default SOCK_CLOEXEC flag on new UnixStream

Currently, the `std::os::unix::net::UnixStream` docs do not specify that the SOCK_CLOEXEC flag is set on new sockets. This commit adds a note clarifying that, in line with the note abuot the `MSG_NOSIGNAL` flag.
@JonathanBrouwer
Rollup merge of rust-lang#150429 - Noratrieb:tier-3-errors, r=Urgau
4af7045 
Improve missing core error for tier 3 targets

Tier 3 targets can't be installed via rustup, so don't recommend that. Additionally, do recommend build-std on stable because it's the recommended way to use these targets, people should switch to nightly.
@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. rollup A PR which is a rollup labels Dec 27, 2025
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Dec 27, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Dec 27, 2025

📌 Commit 4af7045 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2025
@bors
Copy link
Collaborator

bors commented Dec 27, 2025

⌛ Testing commit 4af7045 with merge 50db29b...

@bors
Copy link
Collaborator

bors commented Dec 27, 2025

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing 50db29b to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 27, 2025
@bors bors merged commit 50db29b into rust-lang:main Dec 27, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 27, 2025
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 27, 2025

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#150362 rustdoc: fix duplicate Re-exports sections 130bf9a34d05f513fba123c229508ec30a66439f (link)
#150397 Update hir.rs: fix typo ("aligement" -> "alignment"), confo… 86a53b7df4401ae89fe1b8995cbc0e2d12c53a57 (link)
#150410 Document default SOCK_CLOEXEC flag on new UnixStream feb0da0d7eb21237e79a0cfbd6a5256e0b380483 (link)
#150429 Improve missing core error for tier 3 targets 8c3b586577942d2c1d0803f0db817215e1f57100 (link)

previous master: 4c6706452c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4c67064 (parent) -> 50db29b (this PR)

Test differences

Show 115 test diffs

Stage 1

  • [rustdoc] tests/rustdoc/extern/duplicate-reexports-section-150211.rs: [missing] -> pass (J1)
  • [ui] tests/ui/crate-loading/missing-std-tier-3.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/crate-loading/missing-std-tier-3.rs: [missing] -> pass (J0)
  • [ui] tests/ui/crate-loading/missing-std-tier-3.rs: [missing] -> ignore (gcc backend is marked as ignore) (J2)
  • [rustdoc] tests/rustdoc/extern/duplicate-reexports-section-150211.rs: [missing] -> pass (J3)

Additionally, 110 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 50db29bbd7a2704831ef0eff1f5502647dbb4ec9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 4210.8s -> 3533.5s (-16.1%)
  2. dist-aarch64-llvm-mingw: 5809.4s -> 6279.9s (+8.1%)
  3. aarch64-msvc-2: 6169.6s -> 5682.9s (-7.9%)
  4. dist-aarch64-linux: 6430.3s -> 5946.8s (-7.5%)
  5. x86_64-gnu-gcc: 3529.4s -> 3267.4s (-7.4%)
  6. pr-check-1: 2049.7s -> 1910.5s (-6.8%)
  7. aarch64-msvc-1: 6819.3s -> 7252.9s (+6.4%)
  8. x86_64-msvc-ext2: 6430.4s -> 6028.1s (-6.3%)
  9. dist-x86_64-illumos: 6141.1s -> 5757.0s (-6.3%)
  10. arm-android: 6647.7s -> 6233.9s (-6.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Dec 27, 2025

Finished benchmarking commit (50db29b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.2%, secondary 1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)		 1.5% [1.5%, 1.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.2% [2.2%, 2.2%] 1

Cycles

Results (primary 2.6%, secondary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.6% [2.6%, 2.7%] 2
Regressions ❌
(secondary)		 1.2% [1.2%, 1.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -6.7% [-6.7%, -6.7%] 1
All ❌✅ (primary) 2.6% [2.6%, 2.7%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 484.312s -> 483.295s (-0.21%)
Artifact size: 390.81 MiB -> 390.79 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer @bors @rust-timer @rustbot @heathdutton @BioTomateHP @crescentrose @Noratrieb