-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Constify fmt::from_fn
#150300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Constify fmt::from_fn
#150300
Conversation
This comment has been minimized.
This comment has been minimized.
|
Is this going to be on its own feature flag (which I think will require its own tracking issue)? Although it's a minor change, I would expect it's too late to include it in |
This comment has been minimized.
This comment has been minimized.
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@rustbot label +I-libs-api-nominated +needs-fcp Nominating for @rust-lang/libs-api since this is insta-stable as written. I don't think there would be much benefit to going through a const-unstable period here. |
|
@rfcbot fcp merge libs-api |
|
Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
See #117729 (comment).