-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Mark const SIMD intrinsics as indirectly stable #149648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
cc @rust-lang/wg-const-eval Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr Some changes occurred to the platform-builtins intrinsics. Make sure the cc @antoyo, @GuillaumeGomez, @bjorn3, @calebzulawski, @programmerjake |
|
So you plan to soon const-stabilize functions using these intrinsics? |
|
I won't say soon (it would require t-libs-api approval), but yes the plan is eventually to stabilize them |
|
Usually we do the t-lang FCP for const intrinsics as part of that stabilization, not preemptively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some of these I am not sure they are ready for stabilization.
Also, please give an overview of the test coverage we have for these being invoked from const-eval.
|
r? @RalfJung |
|
@rustbot author I would propose to remove all controversial cases, then we can proceed to FCP. |
|
Reminder, once the PR becomes ready for a review, use |
|
Apologize for the delay. @RalfJung do the above-mentioned caveats also apply to |
|
Yeah, they do. |
9a84c00 to
a87092b
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@rustbot ready I have removed the attributes from |
|
I have nominated this for t-lang discussion. It'd be good to update the PR description to give the required context to team members visiting this during triage: which new capabilities are exposed to const code here, and what does the test coverage look like? |
recently most SIMD intrinsics were made available in const contexts in #147521. This PR makes the indirectly stable to use in const contexts.
cc @RalfJung @rust-lang/lang @rust-lang/wg-const-eval