LLBC-linker and NVPTX: do not strip debug when PTX ISA version >= 7.0 #147672
+38
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
Contributor
Author
|
@rustbot label +O-NVPTX |
Member
|
@RDambrosio016, can you take a look as the other target maintainer for nvptx? |
Contributor
Author
|
@Mark-Simulacrum I see that you swapped the waiting for labels. If this is related to waiting for @RDambrosio016 I don't expect him to check in here. It seems like he's not been checking notifications related to rust-lang for a while. Is there anything I can do to make progress on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #99248
With the version bump of llvm happening a while back it's possible to not strip debug symbols in llbc-linker for the nvptx target in a lot of useful cases.
Instead of always stripping for nvptx64 the new behavior is to look at
target-featureandtarget-cpuand strip for combinations that produce old enough ptx isa version to trigger the bug.