Skip to content

Revert #135914: Remove usages of QueryNormalizer in the compiler#136011

Merged
bors merged 1 commit intorust-lang:masterfrom
compiler-errors:query-norm-vaniquishes-us
Jan 29, 2025
Merged

Revert #135914: Remove usages of QueryNormalizer in the compiler#136011
bors merged 1 commit intorust-lang:masterfrom
compiler-errors:query-norm-vaniquishes-us

Conversation

@compiler-errors
Copy link
Contributor

@compiler-errors compiler-errors commented Jan 24, 2025 •
edited by Zalathar
Loading

Reverts #135914.

r? jackh726

@compiler-errors
Revert "Rollup merge of rust-lang#135914 - compiler-errors:vanquish-q…
4e3e915 
…uery-norm, r=jackh726"

This reverts commit 556d901, reversing
changes made to be15391.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 24, 2025
@jackh726
Copy link
Member

jackh726 commented Jan 24, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 24, 2025

📌 Commit 4e3e915 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2025
@compiler-errors
Copy link
Contributor Author

compiler-errors commented Jan 24, 2025

@bors rollup=never

(perf sensitive 😉)

@Kobzol Kobzol mentioned this pull request Jan 27, 2025
Merged
@fmease
Copy link
Member

fmease commented Jan 29, 2025 •
edited
Loading

Bumping priority above rollup level because it fixes a significant perf regression and because it's been sitting here "in limbo" for four days already

@bors p=6

@bors
Copy link
Collaborator

bors commented Jan 29, 2025

⌛ Testing commit 4e3e915 with merge 122fb29...

@bors
Copy link
Collaborator

bors commented Jan 29, 2025

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 122fb29 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 29, 2025
@bors bors merged commit 122fb29 into rust-lang:master Jan 29, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 29, 2025
@rust-timer
Copy link
Collaborator

rust-timer commented Jan 29, 2025

Finished benchmarking commit (122fb29): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.2%, 0.3%] 16
Improvements ✅
(primary)		 -0.4% [-1.1%, -0.2%] 24
Improvements ✅
(secondary)		 -5.9% [-10.4%, -0.9%] 10
All ❌✅ (primary) -0.4% [-1.1%, -0.2%] 24

Max RSS (memory usage)

Results (primary -0.5%, secondary 1.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.7% [0.7%, 3.5%] 4
Regressions ❌
(secondary)		 2.4% [1.2%, 3.4%] 4
Improvements ✅
(primary)		 -1.9% [-2.9%, -1.0%] 6
Improvements ✅
(secondary)		 -2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) -0.5% [-2.9%, 3.5%] 10

Cycles

Results (secondary -6.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -6.9% [-10.8%, -3.6%] 8
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 768.982s -> 776.092s (0.92%)
Artifact size: 328.22 MiB -> 328.45 MiB (0.07%)

@rustbot rustbot added the perf-regression Performance regression. label Jan 29, 2025
@rylev
Copy link
Member

rylev commented Feb 4, 2025

Marking as triaged since this is a revert.

@rustbot label +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jackh726 jackh726

Labels

merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.

7 participants

@compiler-errors @jackh726 @bors @fmease @rust-timer @rylev @rustbot