bootstrap: still require COMPILETEST_FORCE_STAGE0 for ./x test rustdoc-js --stage 0#135605
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 17, 2025
Merged
Conversation
COMPILETEST_FORCE_STAGE0 for ./x test rustdoc-js --stage 0COMPILETEST_FORCE_STAGE0 for ./x test rustdoc-js --stage 0
Contributor
|
@bors r+ p=1 (contributor roadblock) |
Collaborator
Member
Author
|
@bors rollup (can be rolled up) |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (bb3fa4b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -1.4%, secondary 0.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 765.257s -> 763.565s (-0.22%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #135375, because through some more testing I found out
./x test rustdoc-js --stage 0does not in fact build rustdoc, and all the tests fail. This can't be intended behavior, so at least requireCOMPILETEST_FORCE_STAGE0to make it less likely to runrustdoc-js --stage 0by accident.The problem that
--stage 0is not working at all for this rustdoc-js test suite is tracked over at #135603.cc @lolbinarycat
r? bootstrap