Skip to content

Bump cc in the compiler#135067

Merged
bors merged 1 commit intorust-lang:masterfrom
ChrisDenton:cc
Jan 4, 2025
Merged

Bump cc in the compiler#135067
bors merged 1 commit intorust-lang:masterfrom
ChrisDenton:cc

Conversation

@ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented Jan 3, 2025 •
edited
Loading

Changelog:

  • Regenerate target info (#1342)
  • Allow using Visual Studio target names in find_tool (#1335)
  • Fix is_flag_supported on msvc (#1336)

@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@jieyouxu jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Jan 3, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jan 3, 2025

Only one way to find out.
@bors r+ rollup=never (compiler cc bump tradition)

@bors
Copy link
Collaborator

bors commented Jan 3, 2025

📌 Commit cfe6132 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2025
@bors
Copy link
Collaborator

bors commented Jan 4, 2025

⌛ Testing commit cfe6132 with merge 49761b0...

@bors
Copy link
Collaborator

bors commented Jan 4, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 49761b0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2025
@bors bors merged commit 49761b0 into rust-lang:master Jan 4, 2025
@rustbot rustbot added this to the 1.86.0 milestone Jan 4, 2025
@rust-timer
Copy link
Collaborator

rust-timer commented Jan 4, 2025

Finished benchmarking commit (49761b0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.6% [-3.5%, -1.7%] 2
All ❌✅ (primary) - - 0

Cycles

Results (secondary -1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.3% [-1.3%, -1.3%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 762.547s -> 762.724s (0.02%)
Artifact size: 325.61 MiB -> 325.69 MiB (0.03%)

@ChrisDenton ChrisDenton deleted the cc branch January 4, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jieyouxu jieyouxu

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ChrisDenton @rustbot @jieyouxu @bors @rust-timer @Mark-Simulacrum