Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
|
The Miri subtree was changed cc @rust-lang/miri |
There was a problem hiding this comment.
Oh I forgot this file even exists... I recently had to allow this lint for a use of Size, I suspect that was due to the other import being used.
|
LGTM, thanks! r? @RalfJung |
|
@bors r=RalfJung |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (00ed73c): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -3.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 779.63s -> 780.047s (0.05%) |
I tried to make this a PR to the miri repo for funsies. Ironically, the integration flow meant that it would use a too-old toolchain hash, and I didn't understand the build system there enough to want to manually fiddle with the hashes.