Skip to content

Update cargo#129338

Merged
bors merged 1 commit intorust-lang:masterfrom
weihanglo:update-cargo
Aug 22, 2024
Merged

Update cargo#129338
bors merged 1 commit intorust-lang:masterfrom
weihanglo:update-cargo

Conversation

@weihanglo
Copy link
Member

@weihanglo weihanglo commented Aug 21, 2024 •
edited
Loading

12 commits in ba8b39413c74d08494f94a7542fe79aa636e1661..8f40fc59fb0c8df91c97405785197f3c630304ea
2024-08-16 22:48:57 +0000 to 2024-08-21 22:37:06 +0000

@rustbot
Copy link
Collaborator

rustbot commented Aug 21, 2024

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2024
@weihanglo
Copy link
Member Author

weihanglo commented Aug 21, 2024

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Aug 21, 2024

📌 Commit b1a3c08 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2024
@weihanglo
Copy link
Member Author

weihanglo commented Aug 22, 2024

@bors r+ p=1 rollup=never

This contains a patch rust-lang/cargo#14432 fixing a bug in -Ztarget-applies-to-host that breaks lots of user, so prioritize.

@bors
Copy link
Collaborator

bors commented Aug 22, 2024

📌 Commit 89e7246 has been approved by weihanglo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 22, 2024

⌛ Testing commit 89e7246 with merge 0f6e1ae...

@bors
Copy link
Collaborator

bors commented Aug 22, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 0f6e1ae to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 22, 2024
@bors bors merged commit 0f6e1ae into rust-lang:master Aug 22, 2024
@rustbot rustbot added this to the 1.82.0 milestone Aug 22, 2024
@weihanglo weihanglo deleted the update-cargo branch August 22, 2024 13:37
@rust-timer
Copy link
Collaborator

rust-timer commented Aug 22, 2024

Finished benchmarking commit (0f6e1ae): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.3%, secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.0% [2.0%, 2.0%] 1
Regressions ❌
(secondary)		 2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)		 -2.6% [-2.6%, -2.6%] 1
Improvements ✅
(secondary)		 -2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) -0.3% [-2.6%, 2.0%] 2

Cycles

Results (primary -1.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.2% [-1.2%, -1.2%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.2% [-1.2%, -1.2%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 751.864s -> 749.851s (-0.27%)
Artifact size: 338.88 MiB -> 338.94 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.82.0

Development

Successfully merging this pull request may close these issues.

4 participants

@weihanglo @rustbot @bors @rust-timer