Skip to content

feat: update stdarch submodule for intrinsics on ARM#125163

Merged
bors merged 1 commit intorust-lang:masterfrom
ssukanmi:stdarch_arm_crc32
May 16, 2024
Merged

feat: update stdarch submodule for intrinsics on ARM#125163
bors merged 1 commit intorust-lang:masterfrom
ssukanmi:stdarch_arm_crc32

Conversation

@ssukanmi
Copy link

@ssukanmi ssukanmi commented May 15, 2024

Submodule update for stdarch library
10 commits in c0257c1660e78c80ad1b9136fcc5555b14da5b4c..df3618d9f35165f4bc548114e511c49c29e1fd9b
2024-04-22 01:24:03 +0200 to 2024-05-14 15:52:07 +0200

  • feat: stabilization for stdarch_aarch64_crc32
  • Add vec_insert and vec_extract
  • Remove libc dependency on Windows by using Win32 to get env vars
  • Add vec_orc
  • Simplify vec_andc implementation
  • Silence unexpected-cfgs
  • Add vec_mul
  • Remove #![feature(inline_const)]
  • Add #[cfg_attr(miri, ignore)] to tests of intrinsics that cannot be supported by Miri
  • Implement ARM __ssat and __usat functions

r? Amanieu

@rustbot
Copy link
Collaborator

rustbot commented May 15, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot
Copy link
Collaborator

rustbot commented May 15, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 15, 2024
@Amanieu
Copy link
Member

Amanieu commented May 16, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented May 16, 2024

📌 Commit 0bf8af6 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2024
@bors
Copy link
Collaborator

bors commented May 16, 2024

⌛ Testing commit 0bf8af6 with merge 8c127df...

@bors
Copy link
Collaborator

bors commented May 16, 2024

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 8c127df to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 16, 2024
@bors bors merged commit 8c127df into rust-lang:master May 16, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 16, 2024
@rust-timer
Copy link
Collaborator

rust-timer commented May 17, 2024

Finished benchmarking commit (8c127df): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.0% [-2.0%, -2.0%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.2%, secondary -2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)		 -2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 682.198s -> 678.725s (-0.51%)
Artifact size: 316.23 MiB -> 316.04 MiB (-0.06%)

@ssukanmi ssukanmi deleted the stdarch_arm_crc32 branch May 17, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Amanieu Amanieu

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.80.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ssukanmi @rustbot @Amanieu @bors @rust-timer