Skip to content

aux-bin: Avoid old .so files from old tests; clean auxiliary dir root#124505

Merged
bors merged 2 commits intorust-lang:masterfrom
Enselic:aux-bin-fix
Apr 29, 2024
Merged

aux-bin: Avoid old .so files from old tests; clean auxiliary dir root#124505
bors merged 2 commits intorust-lang:masterfrom
Enselic:aux-bin-fix

Conversation

@Enselic
Copy link
Member

@Enselic Enselic commented Apr 29, 2024

Also fix the typo pointed out here.

Closes #124465

@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2024

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 29, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2024

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@Enselic Enselic mentioned this pull request Apr 29, 2024
Closed
@jieyouxu
Copy link
Member

jieyouxu commented Apr 29, 2024

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 29, 2024

📌 Commit de3eff7 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2024
@bors
Copy link
Collaborator

bors commented Apr 29, 2024

⌛ Testing commit de3eff7 with merge 9084601...

@bors
Copy link
Collaborator

bors commented Apr 29, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 9084601 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 29, 2024
@bors bors merged commit 9084601 into rust-lang:master Apr 29, 2024
@rustbot rustbot added this to the 1.80.0 milestone Apr 29, 2024
@bors bors mentioned this pull request Apr 29, 2024
Merged
@rust-timer
Copy link
Collaborator

rust-timer commented Apr 29, 2024

Finished benchmarking commit (9084601): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.6% [-3.6%, -3.6%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.911s -> 672.94s (0.15%)
Artifact size: 315.98 MiB -> 315.94 MiB (-0.01%)

@Enselic Enselic deleted the aux-bin-fix branch May 1, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@davidtwco davidtwco

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.80.0

Development

Successfully merging this pull request may close these issues.

tests/ui/attributes/unix_sigpipe/unix_sigpipe-inherit.rs no longer passes locally

6 participants

@Enselic @rustbot @jieyouxu @bors @rust-timer @davidtwco