Skip to content

CI: add script for installing NodeJS and update it to v20#123981

Merged
bors merged 1 commit intorust-lang:masterfrom
Kobzol:update-nodejs
Apr 21, 2024
Merged

CI: add script for installing NodeJS and update it to v20#123981
bors merged 1 commit intorust-lang:masterfrom
Kobzol:update-nodejs

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Apr 15, 2024 •
edited
Loading

I centralized the installation on a single place to make it simple to update the NodeJS version across the board.

Fixes: #123965

r? @Mark-Simulacrum

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 15, 2024
@bors
Copy link
Collaborator

bors commented Apr 17, 2024

☔ The latest upstream changes (presumably #123978) made this pull request unmergeable. Please resolve the merge conflicts.

@Kobzol
Copy link
Member Author

Kobzol commented Apr 18, 2024

Rebased.

@rustbot

This comment was marked as outdated.

Sign in to view
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Apr 20, 2024

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Apr 20, 2024

📌 Commit a920ed4 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2024
@bors
Copy link
Collaborator

bors commented Apr 21, 2024

⌛ Testing commit a920ed4 with merge 426a698...

@bors
Copy link
Collaborator

bors commented Apr 21, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 426a698 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 21, 2024
@bors bors merged commit 426a698 into rust-lang:master Apr 21, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 21, 2024
@rust-timer
Copy link
Collaborator

rust-timer commented Apr 21, 2024

Finished benchmarking commit (426a698): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.3% [-0.3%, -0.3%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.3% [-0.3%, -0.3%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 8.5% [8.5%, 8.5%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 8.5% [8.5%, 8.5%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.572s -> 673.693s (0.32%)
Artifact size: 315.28 MiB -> 315.30 MiB (0.01%)

@Kobzol Kobzol deleted the update-nodejs branch April 21, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

Upgrade the Node.js version to 20

5 participants

@Kobzol @bors @rustbot @Mark-Simulacrum @rust-timer